Conversation
Fold the namespace/package rename into the breaking 3.7 release, aligning with the ptr727.* style of the sibling LanguageTags project. - Rename InsaneGenius.Utilities -> ptr727.Utilities (namespace, PackageId, RootNamespace); bare AssemblyName (Utilities / UtilitiesTests) and InternalsVisibleTo (breaking). - Move localized library suppressions (CA1024/CA1034/CA1054/CA5394) to symbol-scoped [SuppressMessage] attributes; drop dead test suppressions (CA1307/CA2007) and the unused IClassFixture fixture (CA1823/IDE0052/CA1063). - Make Format.BytesToKibi/BytesToKilo culture-invariant. - Derive the HttpClient User-Agent from the consuming application (AOT-safe), always setting a header. - Add GlobalUsings.cs per project; document both breaking 3.7 changes (namespace and logging) in README and HISTORY.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the InsaneGenius.Utilities -> ptr727.Utilities rename (package + root namespace) and the associated cleanups/adjustments into main for the 3.7 breaking release.
Changes:
- Renames package IDs, root namespaces, and test namespaces to
ptr727.Utilities*, and standardizes assembly names (Utilities,UtilitiesTests). - Adds per-project
GlobalUsings.csand removes now-redundant per-fileusingdirectives/suppressions. - Fixes culture-dependent byte formatting output (invariant formatting) and updates
Download’s HttpClient User-Agent derivation logic.
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| UtilitiesTests/UtilitiesTests.csproj | Updates test project PackageId/AssemblyName/RootNamespace for the rename. |
| UtilitiesTests/UtilitiesTests.cs | Removes unused fixture type previously used only for suppression/structure. |
| UtilitiesTests/StringHistoryTests.cs | Moves tests into ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/StringCompressionTests.cs | Moves tests into ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/StringCompressionAsyncTests.cs | Moves tests into ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/LogOptionsTests.cs | Updates test namespace to ptr727.Utilities.Tests. |
| UtilitiesTests/GlobalUsings.cs | Adds global Xunit using for tests. |
| UtilitiesTests/FormatTests.cs | Updates test namespace to ptr727.Utilities.Tests. |
| UtilitiesTests/FileTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/FileExAsyncTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/ExtensionsTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/DownloadTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/DownloadAsyncTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/ConsoleTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/CommandLineTests.cs | Updates test namespace to ptr727.Utilities.Tests and drops unused fixture wiring. |
| UtilitiesTests/.editorconfig | Removes suppressions made unnecessary by fixture removal; keeps test-appropriate analyzer relaxations. |
| Utilities/Utilities.csproj | Renames package + root namespace; standardizes assembly name; updates InternalsVisibleTo. |
| Utilities/StringHistory.cs | Renames namespace to ptr727.Utilities. |
| Utilities/StringCompression.cs | Renames namespace to ptr727.Utilities. |
| Utilities/LogOptions.cs | Renames namespace to ptr727.Utilities and relies on global logging using. |
| Utilities/GlobalUsings.cs | Adds global Microsoft.Extensions.Logging using for the library project. |
| Utilities/Format.cs | Renames namespace and makes byte formatting culture-invariant. |
| Utilities/FileExOptions.cs | Renames namespace to ptr727.Utilities. |
| Utilities/FileEx.cs | Renames namespace and localizes CA5394 suppression to the relevant methods. |
| Utilities/Extensions.cs | Renames namespace and localizes CA1034 suppression to the relevant type. |
| Utilities/Download.cs | Renames namespace; localizes CA1024/CA1054 suppressions; changes User-Agent derivation. |
| Utilities/ConsoleEx.cs | Renames namespace to ptr727.Utilities. |
| Utilities/CommandLineEx.cs | Renames namespace to ptr727.Utilities. |
| Utilities/.editorconfig | Removes broad suppressions in favor of symbol-scoped [SuppressMessage]. |
| Sandbox/Sandbox.csproj | Updates sandbox RootNamespace to ptr727.Utilities.Sandbox. |
| Sandbox/Program.cs | Updates using directives to the new namespaces and relies on global Serilog using. |
| Sandbox/LoggerFactory.cs | Updates namespace to ptr727.Utilities.Sandbox and relies on global Serilog using. |
| Sandbox/GlobalUsings.cs | Adds global Serilog using for the sandbox project. |
| README.md | Updates documentation and NuGet references for the rename and breaking-change notes. |
| HISTORY.md | Records the 3.7 breaking rename in release history. |
| codecov.yml | Updates comment text to reference ptr727.Utilities. |
| AGENTS.md | Updates agent guidance text to reflect the new package identity. |
The non-packable UtilitiesTests project publishes nothing, so its stale Azure DevOps PackageProjectUrl is dead metadata. The library keeps its GitHub PackageProjectUrl.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 40.23% 40.62% +0.38%
==========================================
Files 10 10
Lines 1009 1024 +15
Branches 97 99 +2
==========================================
+ Hits 406 416 +10
- Misses 577 580 +3
- Partials 26 28 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the
ptr727.Utilitiesrename fromdeveloptomain, folded into the breaking 3.7 release. Full detail and review history in #384.Highlights
InsaneGenius.Utilities->ptr727.Utilitiesacross namespaces,usingdirectives,PackageId, andRootNamespace; bareAssemblyName(Utilities/UtilitiesTests) andInternalsVisibleTo, matching the siblingLanguageTagsproject. Both 3.7 breaking changes (namespace and the logging model) are marked consistently in README and HISTORY.[SuppressMessage]; dead test suppressions (CA1307/CA2007) and the vestigialIClassFixturefixture removed (CA1823/IDE0052/CA1063).Format.BytesToKibi/BytesToKiloare now culture-invariant.Verification
dotnet format+ editorconfig, NativeAOT publish verified.🤖 Generated with Claude Code