Skip to content

Record develop-staleness and issue-closing learnings in AGENTS.md#366

Merged
ptr727 merged 1 commit into
developfrom
docs/agents-learnings
Jul 3, 2026
Merged

Record develop-staleness and issue-closing learnings in AGENTS.md#366
ptr727 merged 1 commit into
developfrom
docs/agents-learnings

Conversation

@ptr727

@ptr727 ptr727 commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Two durable learnings: mirror main-only fixes to develop (and check git diff origin/develop origin/main before relying on develop), and put Closes #N in the promotion PR. No code changes.

Copilot AI review requested due to automatic review settings June 30, 2026 04:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates AGENTS.md to document two process learnings around branch divergence and issue-closing semantics, with no code changes.

Changes:

  • Add guidance to detect when develop is stale relative to main and to mirror main-only fixes onto develop.
  • Add guidance to place issue-closing keywords where they will actually close issues on the default branch (main).

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread AGENTS.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit fea77e9 into develop Jul 3, 2026
10 checks passed
@ptr727
ptr727 deleted the docs/agents-learnings branch July 3, 2026 17:47
ptr727 added a commit that referenced this pull request Jul 3, 2026
Promotes the two commits currently ahead on `develop` to `main`.

Closes #329
Closes #339

## What's promoted
- **#367** - carry the template's "In a derived repo:" upstream-drift
reporting paragraph into `.github/copilot-instructions.md`. This was the
last substantive verbatim-carry gap from a full audit of both
convergence issues against `ptr727/ProjectTemplate`.
- **#366** - record two CI/CD process learnings in `AGENTS.md` (mirror
main-only fixes back to `develop` with a content-diff staleness check;
put `Closes #N` on the promotion PR), converged through the Copilot
review loop.

## Convergence audit (why #329 and #339 are done)
Audited every item in both issues against the current template. This
repo is intentionally NuGet-only, no codegen, no Docker, so most items
were already converged by prior work:
- **#329**: the Copilot review runbook
(`.github/copilot-instructions.md`), the AGENTS.md "PR Review Etiquette"
contract, and `.markdownlint-cli2.jsonc` (byte-identical to the
template) are all present. Only the "In a derived repo:" paragraph was
missing (#367).
- **#339**: `.editorconfig` `[*.cs]` marked .NET-only with matching
per-extension EOL rules; AGENTS.md comments house-rule, markdown
trailing-backslash, and versioning-without-"develop-ahead";
`CODESTYLE.md` (General + .NET, Python dropped); `retention-days: 1` on
the one artifact upload. Docker registry-cache guidance is N/A (no
Docker workflow).

Remaining differences are intentional, repo-accurate divergence
(NuGet-only project names, `CODESTYLE.md` build-requirements text
matching this repo's actual `Directory.Build.props`).

## Not included
Issue **#348** (branch-ruleset drift: extra `creation` rule +
`do_not_enforce_on_create`) is maintainer-gated live GitHub config and
is intentionally left for a maintainer decision (whether the extra
`creation` rule is intended). Surfaced separately, not closed here.

## Diff
`develop` is a clean superset of `main` (4 insertions across two doc
files, no deletions - no `main`-only stragglers).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants