feat: set default log driver for service containers to 'local'#83
Merged
psviderski merged 2 commits intopsviderski:mainfrom Jun 27, 2025
Merged
feat: set default log driver for service containers to 'local'#83psviderski merged 2 commits intopsviderski:mainfrom
psviderski merged 2 commits intopsviderski:mainfrom
Conversation
psviderski
reviewed
Jun 26, 2025
Owner
psviderski
left a comment
psviderski
left a comment
There was a problem hiding this comment.
Thank you for the contribution! Please see a couple comments regarding using a global default for uncloud.
zasdaym
force-pushed
the
default-docker-log-driver
branch
from
1eb15d8 to
773f9ab
Compare
Contributor
Author
|
I think it's better to set it on |
Owner
Ah yeah agreed, this is even better! |
Owner
|
Please see the failed tests, looks like we need to fix the nil vs empty map comparison in |
psviderski
changed the title
psviderski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #49