fix(configs): Create non-existent parent directories automatically#233
fix(configs): Create non-existent parent directories automatically#233
Conversation
tonyo
force-pushed
the
tonyo/fix-configs-nested-1
branch
from
3d878ee to
486f80b
Compare
psviderski
left a comment
psviderski
left a comment
There was a problem hiding this comment.
Excellent! Just one note about the Equal implementation for the config mounts. We can do it in a separate PR. It's up to you to decide, just raising to not forget.
| @@ -71,5 +78,11 @@ func configSpecsFromCompose( | |||
| configMounts = append(configMounts, mount) | |||
There was a problem hiding this comment.
Just found out that ContainerSpec.Equal depends on the order of config mounts. This is not a big deal as usually people update and deploy the same Compose file so the order of service.configs normally stays the same hence the spec comparison works as expected.
However, while we're on this, it would be good to make the comparison order agnostic, like with volume mounts to not trigger a spec change/redeployment if only the order is different:
Lines 289 to 300 in 79dc05c
There was a problem hiding this comment.
Makes sense, but will handle it in another PR
2 participants
Fixes #232 and another issue that didn't allow to create two config mounts with the same source config.
It should more closely mirror now the Compose behavior which also uses the full target path in the tar header and extracts it to the root: