[spike] refactor/feat: Abstract cli table rendering and add JSON output format#191
Draft
jabr wants to merge 1 commit intopsviderski:mainfrom
Draft
[spike] refactor/feat: Abstract cli table rendering and add JSON output format#191jabr wants to merge 1 commit intopsviderski:mainfrom
jabr wants to merge 1 commit intopsviderski:mainfrom
Conversation
jabr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An AI generated draft of the table refactor with JSON output format idea. #165 (comment)
Not sure how I feel about the overall implementation it took here, but it seemed like a useful draft to start a conversation on how we want to do it.
In brief, this approach is basically "JSON-first" now, generating structs that are more or less directly output for the JSON "format" and then the standard TUI table format is just defining column->field map with optional transforms, like "-" for nil, humanized times, etc.
It also uses lipgloss table for everything now, rather than tabwriter. Not sure if there's any reason to not... do we want to keep tabwriter for some commands? Or as another output option (a simpler, non-styled version)?