Add PSI_API for C_DTRSV #3311
Merged
Add PSI_API for C_DTRSV #3311
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiborGY
reviewed
Jul 22, 2025
| void C_DSYRK(char uplo, char trans, int n, int k, double alpha, double* a, int lda, double beta, double* c, int ldc); | ||
| void C_DSYR2K(char uplo, char trans, int n, int k, double alpha, double* a, int lda, double* b, int ldb, double beta, | ||
| double* c, int ldc); | ||
| PSI_API |
Contributor
There was a problem hiding this comment.
For the record, can we get a comment saying why this was added to the API?
Contributor
Author
There was a problem hiding this comment.
Actually I do not know why only certain functions are available via the API. Anyway, I revise the generalized minimal residual algorithm in forte and one of the steps is to solve a triangular system.
Member
There was a problem hiding this comment.
Thanks, @lcyyork. Not all functions are available through the C++ API just to keep it slim. And Tibor's suggestion to document the "why" is handy for a contact point in case we want to alter the interface.
I'm going to update the branch to probe why Azure doesn't seem to be responding. Nothing to do with the PRs content in particular.
loriab
approved these changes
Jul 23, 2025
jturney
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PSI_API for C_DTRSV.
User API & Changelog headlines
Dev notes & details
Questions
Checklist
Status