Skip to content

Conversation

@TiborGY
Copy link
Contributor

@TiborGY TiborGY commented May 21, 2024

Description

It looks like libmints/svd.cc is unused. Psi4 appears to build just fine without it. It contains what looks like ancient LAPACK code that was auto-translated with f2c.

This PR deletes the file.

User API & Changelog headlines

  • None

Dev notes & details

  • Unused file libmints/svd.cc is deleted

Checklist

  • No new features
  • Tests run by the CI are passing

Status

  • Ready for review
  • Ready for merge

@TiborGY TiborGY marked this pull request as ready for review May 22, 2024 20:29
@TiborGY TiborGY changed the title try deleting the svd file from libmints Delete unused file: libmints/svd.cc May 22, 2024
@TiborGY TiborGY force-pushed the del_svd branch 2 times, most recently from cabe139 to 71d602d Compare June 4, 2024 22:18
@JonathonMisiewicz JonathonMisiewicz added this pull request to the merge queue Jun 6, 2024
@JonathonMisiewicz JonathonMisiewicz added this to the Psi4 1.10 milestone Jun 6, 2024
Merged via the queue into psi4:master with commit edffea3 Jun 6, 2024
@TiborGY TiborGY deleted the del_svd branch June 6, 2024 21:37
@loriab loriab mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants