Skip to content

Conversation

@TiborGY
Copy link
Contributor

@TiborGY TiborGY commented May 21, 2024

Description

Detci still has a few places where error termination is effected through printf+abort(). This PR replaces the calls to abort() in with throw PSIEXCEPTION(msg).

The rest of the codebase has more of this pattern, those are subject to future PRs to keep this one small.

User API & Changelog headlines

  • A few error terminations in the detci module now print a more detailed error information to the console, instead of just the error message in the output file.

Dev notes & details

  • Calls to abort() in detci are replaced with throw PSIEXCEPTION(msg), where msg is the relevant error message taken from the context of the abort()

Checklist

  • No new features
  • Tests run by the CI are passing

Status

  • Ready for review
  • Ready for merge

Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up!

@loriab loriab added this pull request to the merge queue Jun 4, 2024
@loriab loriab added the cleanup For issues where the goal is to make Psi4 a little cleaner. label Jun 4, 2024
@loriab loriab added this to the Psi4 1.10 milestone Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@JonathonMisiewicz JonathonMisiewicz added this pull request to the merge queue Jun 6, 2024
Merged via the queue into psi4:master with commit 83e981e Jun 6, 2024
@TiborGY TiborGY deleted the dont_abort branch June 6, 2024 21:38
@loriab loriab mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup For issues where the goal is to make Psi4 a little cleaner.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants