qcfractal v0.52 #3090
Merged
qcfractal v0.52 #3090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
approved these changes
Nov 30, 2023
susilehtola
reviewed
Dec 1, 2023
CMakeLists.txt
Outdated
Comment on lines
5
to
7
| if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.27.0") | ||
| cmake_policy(SET CMP0144 NEW) | ||
| endif() |
Member
There was a problem hiding this comment.
Note that the policy doesn't work in CMake 3.27.7, see #3092
davpoolechem
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(To review, turn on "hide whitespace" at the little gear to see that task_base changes are just deleted alternate logic.)
User API & Changelog headlines
Dev notes & details
he urllib3 thing I think might help the Win nightly build uploadsQuestions
Checklist
Status