Throw exceptions for broken JK+SCREENING combos #3081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davpoolechem
force-pushed
the
dpoole34/noscreen-except
branch
from
39c3c24 to
437eb73
Compare
loriab
approved these changes
Nov 28, 2023
Member
loriab
left a comment
loriab
left a comment
There was a problem hiding this comment.
I'm glad you have a good handle on compatible combos -- I would need a table :-)
davpoolechem
force-pushed
the
dpoole34/noscreen-except
branch
from
e615184 to
b5c3643
Compare
jturney
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an intermediary PR to #3060. Reviews on that PR have made me reconsider some design decisions as implemented in that PR. At the same time, I want to ensure that no end user runs into any hard failures due to broken
SCF_TYPE+SCF_SUBTYPE+SCREENINGcombinations in v1.9. So this PR goes and simply throws exceptions for every hard failure case as logged intest_comprehensive_jk_screening.py. Tests are updated to match, and there's some small refactoring of how JK type + screening exceptions are handled injk.cc.User API & Changelog headlines
Dev notes & details
SCF_TYPE+SCF_SUBTYPE+SCREENINGnow throw an exception, instead of running to failure.Questions
Checklist
Status