Remove new's in SOBasis #3024
Merged
Remove new's in SOBasis #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loriab
approved these changes
Aug 14, 2023
Member
loriab
left a comment
loriab
left a comment
There was a problem hiding this comment.
Looks reasonable to me and certainly much tidier. If there's another cause for a new commit, the comments in the header file that got disassociated with the member data/fns could be added back.
loriab
added
libmints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A quick cleanup removing
newanddeletein favor ofstd::vectorin SOBasis.User API & Changelog headlines
Dev notes & details
Questions
Checklist
Status