fix pcmsolver on windows #2972
Merged
fix pcmsolver on windows #2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxscheurer
approved these changes
Jun 1, 2023
maxscheurer
approved these changes
Jun 22, 2023
Member
|
What's the effect, does this leave the temporary files hanging? |
Member
Author
Probably yes, adding to the misc temp files from pcm https://github.com/psi4/psi4/blob/master/tests/pytests/conftest.py#L52-L53 . I guess we could try to add these to on-exit like the numpy files. |
Member
Author
|
ok, for linux at least, this cleans up both files usually or retains them if run as |
jturney
approved these changes
Jun 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
loriab
added a commit
that referenced
this pull request
Jul 10, 2023
* Update python_helpers.py * Update extras.py * Update python_helpers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User API & Changelog headlines
Dev notes & details
Checklist
Tests added for any new featuresStatus