Enable dd-solvated TDSCF #2967
Merged
Enable dd-solvated TDSCF #2967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
maxscheurer
approved these changes
May 23, 2023
Contributor
maxscheurer
left a comment
maxscheurer
left a comment
There was a problem hiding this comment.
Neat! Glad the cpscf interface seems to work with more and more models 😄
Contributor
Author
|
I don't really see if the CI failures are related to my changes. @loriab Any ideas? |
Contributor
|
The problems are unrelated to this PR. Rebase and push, and the problems will be fixed. (Psi's "grab the latest pydantic" will use an updated pydantic, which won't raise the error.) I'll review this PR later today, since I know the TDSCF code the best, nowadays. |
JonathonMisiewicz
approved these changes
May 24, 2023
| can only be used for energy calculations with SCF | ||
| wavefunctions. All ERI algorithms (``PK``, ``OUT_OF_CORE``, ``DIRECT``, ``DF``, | ||
| ``CD``) are supported. | ||
| .. note:: At present PCM can only be used for energy calculations with SCF |
Contributor
There was a problem hiding this comment.
Suggested change
| .. note:: At present PCM can only be used for energy calculations with SCF | |
| .. note:: At present, PCM can only be used for energy calculations with SCF |
Member
|
The Win failures are the pydantic 1.10.7 + typing extensions 4.6 we were seeing yesterday. It should have cleared up, some I'm retriggering one to check. |
Contributor
Author
|
Thanks @JonathonMisiewicz and @loriab ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends DDX interface to support SCF response and TDSCF.
Checklist
Status