Skip to content

Conversation

@loriab
Copy link
Member

@loriab loriab commented May 2, 2023

Description

Note: this isn't going to pass until after #2946

Dev notes & details

  • We had the odd situation where the install directories (GNUInstallDirs) were pretty flexible. But it wasn't quite flexible enough for the usual Windows install layout (see https://github.com/psi4/psi4/blob/master/conda/win/meta.yaml#L32-L41). And if you got those all in the right place, the paths computation in run_psi4.py (-> bin/psi4) and psi4/__init__.py wasn't quite as flexible as GNUInstallDirs allowed. So I modernized the lot with pathlib and hopefully systemitized it a bit, too.
  • There's a weird case on linux c-f where we're in a git repo, but it's not the psi git repo. Thus versioning is much confused. The versioner can now escape from that case and version as if tarball.

Checklist

Status

  • Ready for review
  • Ready for merge

@loriab loriab added the build label May 2, 2023
@loriab loriab added this to the Psi4 1.8 milestone May 2, 2023
@loriab loriab marked this pull request as draft May 2, 2023 05:21
@loriab loriab force-pushed the modernizepaths branch from 32cbb05 to 77e90ac Compare May 2, 2023 16:29
@loriab loriab marked this pull request as ready for review May 2, 2023 16:30
Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamped.

@loriab loriab added this pull request to the merge queue May 2, 2023
Merged via the queue into psi4:master with commit 64c9b12 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants