Skip to content

Conversation

@maxscheurer
Copy link
Contributor

@maxscheurer maxscheurer commented May 1, 2023

Description

As it says in the title, see #2942 and #2938.

Closes #2942

User API & Changelog headlines

  • adcc version 0.15.16 at least required due to bugfixes in adcc

Dev notes & details

  • Check adcc min version at runtime

Questions

  • Question1

Checklist

closes #2938 closes #2942

Status

  • Ready for review
  • Ready for merge

@maxscheurer maxscheurer added this to the Psi4 1.8 milestone May 1, 2023
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Do you want to store the ref gen script in the repo?

@maxscheurer
Copy link
Contributor Author

maxscheurer commented May 1, 2023

Looks great, thanks! Do you want to store the ref gen script in the repo?

I don't know where exactly... I'd have stored it in the adcc repo maybe, unless you have a suggestion where to put it.

@loriab
Copy link
Member

loriab commented May 1, 2023

I don't know where exactly... I'd have stored it in the adcc repo maybe, unless you have a suggestion where to put it.

That's fine. Or if you want it here, maybe tests/pytests/test_adcc/

@loriab loriab enabled auto-merge May 1, 2023 15:33
@maxscheurer maxscheurer mentioned this pull request May 1, 2023
2 tasks
@loriab loriab added this pull request to the merge queue May 1, 2023
Merged via the queue into psi4:master with commit 030f622 May 1, 2023
@maxscheurer maxscheurer deleted the update_adcc1516 branch May 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update to adcc 0.15.16

3 participants