Skip to content

Remove now-unused libqt Davidson solver #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davpoolechem merged 1 commit into from
Apr 21, 2023
Merged

Remove now-unused libqt Davidson solver #2925

davpoolechem merged 1 commit into from
Apr 21, 2023

Conversation

@TiborGY
Copy link
Contributor

@TiborGY TiborGY commented Apr 20, 2023 •
edited
Loading

Description

PR #2684 has removed the last remaining call site of the libqt Davidson solver. This PR removes this unused function and file.
The file will be submitted to the attic after this is merged.

User API & Changelog headlines

  • None, david was not PSI_API

Dev notes & details

  • Unused libqt function david and its file are removed.
  • Declared-but-never-defined function print_block is removed from qt.h

Checklist

  • No new features
  • CI tests are passing

Status

  • Ready for review
  • Ready for merge

davpoolechem
davpoolechem reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@davpoolechem davpoolechem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but one question before I approve.

What's the plan with libqt's schmidt_add function? It seems that, with this PR, libqt's schmidt_add finds no other use in the code. Given it is already deprecated, I take it that will be removed in a later PR?

@TiborGY
Copy link
Contributor Author

TiborGY commented Apr 21, 2023

Everything looks good, but one question before I approve.

What's the plan with libqt's schmidt_add function? It seems that, with this PR, libqt's schmidt_add finds no other use in the code. Given it is already deprecated, I take it that will be removed in a later PR?

Exactly.

@davpoolechem
Copy link
Contributor

davpoolechem commented Apr 21, 2023

Everything looks good, but one question before I approve.
What's the plan with libqt's schmidt_add function? It seems that, with this PR, libqt's schmidt_add finds no other use in the code. Given it is already deprecated, I take it that will be removed in a later PR?

Exactly.

All right, that works for me!

@davpoolechem davpoolechem added this pull request to the merge queue Apr 21, 2023
Merged via the queue into psi4:master with commit bba1fc6 Apr 21, 2023
@loriab loriab added this to the Psi4 1.8 milestone Apr 21, 2023
@loriab loriab added the cleanup For issues where the goal is to make Psi4 a little cleaner. label Apr 21, 2023
@TiborGY TiborGY deleted the rem_qt_david branch April 21, 2023 15:51
TiborGY added a commit to TiborGY/psi4attic that referenced this pull request Apr 22, 2023
@TiborGY
Update libqt Davidson solver to its final version
c06c974 
Removed from main repo by psi4/psi4#2925
@TiborGY TiborGY mentioned this pull request Apr 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davpoolechem davpoolechem davpoolechem approved these changes

@JonathonMisiewicz JonathonMisiewicz JonathonMisiewicz approved these changes

Assignees

No one assigned

Labels

cleanup For issues where the goal is to make Psi4 a little cleaner.

Projects

None yet

Milestone

Psi4 1.8

Development

Successfully merging this pull request may close these issues.

4 participants

@TiborGY @davpoolechem @JonathonMisiewicz @loriab