Skip to content

Conversation

@TiborGY
Copy link
Contributor

@TiborGY TiborGY commented Nov 30, 2022

Description

libqt/ras_set.cc has a lot of commented-out code in it, some of it would not even compile anymore.
qt.h declares a pair of functions that are never defined, but would be used in the commented-out ras_set code.
This PR removes this dead code.

User API & Changelog headlines

Dev notes & details

  • Commented out code is removed from libqt/ras_set.cc
  • Declarations of int* get_frzcpi() and int* get_frzvpi() are removed from qt.h

Checklist

  • No new features
  • Tests run by the CI are passing

Status

  • Ready for review
  • Ready for merge

@TiborGY TiborGY marked this pull request as ready for review December 2, 2022 16:00
@loriab loriab added this to the Psi4 1.8 milestone Jan 25, 2023
@loriab loriab added cleanup For issues where the goal is to make Psi4 a little cleaner. detci For issues with the DETCI module. labels Jan 25, 2023
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that CDS is good with this

@loriab loriab merged commit 58efb60 into psi4:master Jan 25, 2023
@TiborGY TiborGY deleted the remove_dead_ras branch January 26, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup For issues where the goal is to make Psi4 a little cleaner. detci For issues with the DETCI module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants