Remove unused diag method. #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
added
cleanup
TiborGY
reviewed
Nov 17, 2022
maxscheurer
approved these changes
Nov 17, 2022
loriab
reviewed
Nov 21, 2022
| The ``SEM`` method is the most robust, but it also | ||
| requires $2NM+1$ CI vectors on disk, where $N$ is the maximum number of | ||
| iterations and $M$ is the number of roots. -*/ | ||
| options.add_str("DIAG_METHOD", "SEM", "RSP DAVIDSON SEM"); |
Member
There was a problem hiding this comment.
It looks like SEMTEST hasn't been accessible except through recompile.
Removal is fine by me, but I agree CDS needs final say wrt utility of this mode.
CDSherrill
approved these changes
Nov 22, 2022
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev notes & details
detci. Part of 2640.Status