Remove unused psio_* functions #2724
Conversation
JonathonMisiewicz
left a comment
JonathonMisiewicz
left a comment
There was a problem hiding this comment.
Given how difficult PSIO is to use for non-experts (which is anybody who is going to be using it nowadays), I'd rather keep thin but descriptive wrappers.
|
btw, don't exert much effort on anything only used by optking as hopefully that gets deleted by end of year. |
Very well. The two functions in question are now preserved. |
loriab
left a comment
loriab
left a comment
There was a problem hiding this comment.
Looks reasonable to me, and will help define more tightly the needed I/O interface. Would be good to get 3rd review from an early developer.
|
Just to confirm: these are almost all just removal of the C-based wrapper functions, correct? |
Yes. As far as I can tell different modules seem to be using PSIO in slightly different ways. The newer modules tend to create their own PSIO object and then call its member functions, but older modules seem to be more reliant on global state. To satisfy this, there is a "global PSIO object", and some wrapper functions have been written that usually do the same thing as the corresponding PSIO member functions, except they are regular functions and they manipulate the "global PSIO object". This PR removes the unused ones. |
|
Yes, I believe the global PSIO object was to created to minimize the changes needed to older modules that worked with the pre-OOP version of the library. |
loriab
added
the
cleanup
4 participants
Description
There are some IO functions declared in psio.h instead of psio.hpp, which manipulate the state of the global PSIO object. Some of these functions are never called, a few other functions are declared but never defined.
This PR removes them.
User API & Changelog headlines
Dev notes & details
Status