DFHelper Readability 2 #2654
Merged
DFHelper Readability 2 #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
added
the
cleanup
loriab
reviewed
Aug 1, 2022
Co-authored-by: Lori A. Burns <[email protected]>
loriab
approved these changes
Aug 4, 2022
hokru
approved these changes
Aug 11, 2022
zachglick
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The next batch of readability fixes to
dfhelper.cc. The potentially contentious issue here is that I remove theAO_files_variable, which was just an identity mapping.Plenty more cleanup to go!
Checklist
Status