Port cc19, cc28, modify cc29
#2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
added
testing
cc
maxscheurer
approved these changes
Feb 18, 2022
Contributor
|
Looks good. |
jturney
approved these changes
Feb 18, 2022
loriab
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a docs fail caused by the previous PR in the series and also adapts a few more tests. Test
cc29needs another adaptation, but as that will require a new psivar, I'm saving that for the next PR.This is PR 5 in an ongoing series to make
ccdensitycompatible with the standardMatrixandWavefunctionmachinery used elsewhere in Psi. Obligatory @lothian ping forccand obligatory @loriab ping for fixing the docs.Status