-
Notifications
You must be signed in to change notification settings - Fork 475
Fix guess mix with SAD and other guesses #2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The PR mostly looks good. A few questions:
|
Co-authored-by: Jonathon Misiewicz <[email protected]>
It means I was able to quickly identify the issue and throw together a simple fix, but not to test it ;) I still don't have a working Psi4 compile environment due to the libint2 incompatibility. Once that gets fixed, I'll have to push to get newer versions of Psi4 to compile again in Fedora. |
|
So... looks like it works; DIIS just takes it to the wrong solution |
|
OK, tests appear to pass now with all guesses. I can't generate |
|
Running the same test but with different options is a perfect reason to write a pytest rather than a C-test, and no Thanks for the debugging thus far! |
| } | ||
|
|
||
| // SAD doesn't have orbitals in iteration 0, other guesses do | ||
| bool have_orbitals = !sad_ || (sad_ && iteration_ > 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my ideal world, we could just check if Ca_ was nullptr, but getting Psi to such a state is beyond-the-scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup...
|
Accidentally pushed rather than made a PR to your fork. Oops. LMK if you object, @susilehtola. |
that's fine |
Description
The current guess mix code runs in iteration 0, but SAD doesn't have orbitals there, while some other guesses don't call
form_Cin iteration 0. This PR fixes guess_mix for all guesses.Todos
Questions
Checklist
Status