disables wcombine option #2362
Merged
disables wcombine option #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
approved these changes
Nov 22, 2021
loriab
approved these changes
Nov 22, 2021
andysim
approved these changes
Nov 22, 2021
Member
andysim
left a comment
andysim
left a comment
There was a problem hiding this comment.
Thanks for addressing this :) Hopefully I can find some time to dig into the problem during next week's hackathon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports indicate that the in-core
MemDF+wcombinealgorithm is not working correctly.This PR disables the options. MemDF does not longer turn the option on automatically and users setting the option directly will get an exception error. A note is added to the DFT manual.
Issues: #2351 #2279
Related: #2283
Status