Fix DIIS memory leak #2350
Merged
Fix DIIS memory leak #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
added
the
efficiency
JonathonMisiewicz
force-pushed
the
diisfix
branch
from
9489614 to
b8874d0
Compare
jturney
approved these changes
Nov 11, 2021
Member
jturney
left a comment
jturney
left a comment
There was a problem hiding this comment.
Seems reasonable to use std::move like you did. LGTM
loriab
approved these changes
Nov 11, 2021
hokru
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a memory leak which I inadvertently introduced myself when refactoring
libdiis.What I was trying to do was take heap memory and move it into the stack. You can't actually do that. So when I released my
std::vectorfrom the smart pointer and saved it to a class variable, the memory was not cleared on object delete because it was still heap memory and not stack memory. Mea culpa.Checklist
Status