Fix invalid setuptools config in setup.cfg (will fail on setuptools>78.0.0)#6920
Open
abravalheri wants to merge 2 commits intopsf:mainfrom
Open
Fix invalid setuptools config in setup.cfg (will fail on setuptools>78.0.0)#6920abravalheri wants to merge 2 commits intopsf:mainfrom
setup.cfg (will fail on setuptools>78.0.0)#6920abravalheri wants to merge 2 commits intopsf:mainfrom
Conversation
setup.cfgsetup.cfg (will fail on `setuptools>78.0.0)
setup.cfg (will fail on `setuptools>78.0.0)setup.cfg (will fail on setuptools>78.0.0)
2 tasks
|
It feels like removing stuff from |
Author
Fair enough, as I mentioned before, if the maintainers are interested:
In my opinion that would be best case scenario, but I don't know if there is a preference for centralising all the configs in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 78 of setuptools, the invalid configuration in
setup.cfgwill start to fail (there has been a deprecation warning since 3 Mar 2021).I also noticed that most of the information provided to
setup.cfgis repeated insetup.py, so I removed the duplicated copies insetup.cfg, because the project seems to be primarily usingsetup.py.Alternatively, I can also try to migrate the static configs to
pyproject.tomlif desired (please let me know).