Disable pytest messing with warnings.#4056
Conversation
We may be able to remove this if pytest resolves pytest-dev/pytest#2430
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Looks good when builds finish.
|
I want to point out that it's pretty stupid that we have to do this, but there we are. |
Codecov Report
@@ Coverage Diff @@
## master #4056 +/- ##
==========================================
+ Coverage 86.66% 89.75% +3.08%
==========================================
Files 15 15
Lines 1942 1942
==========================================
+ Hits 1683 1743 +60
+ Misses 259 199 -60
Continue to review full report at Codecov.
|
Hi @Lukasa, sorry to hear that this affected you guys so. We are having some discussion related to this on pytest-dev/pytest#2430, it mean a lot if you could join the discussion and share your thoughts. 👍 |
|
@niccoddemus Yeah, I saw that thread. I am not sure how much value I can provide by weighing in: your warnings filter as added prevented us from tweaking the filter ourselves for testing purposes. I can drop in though. |
5 participants
We may be able to remove this if pytest resolves pytest-dev/pytest#2430, but until that point we need to turn the old behaviour back on.