Skip to content

Comments

Packaging the tests, or not#287

Merged
frostming merged 2 commits intopsf:masterfrom
dimbleby:packaging-tests
May 29, 2023
Merged

Packaging the tests, or not#287
frostming merged 2 commits intopsf:masterfrom
dimbleby:packaging-tests

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Sep 13, 2022

Fixes #281, #282

  • first commit explicitly excludes tests from the binary distribution, it is indeed unconventional to include them
  • second commit explicitly re-adds them to the source distribution
    • I don't think there's universal consensus about whether this is desirable or not eg here is a recent discussion
    • but it seems harmless and seeing as how No tests in pypi sdist tarball #281 explicitly asks for them, well why not?

@itamarst
Copy link
Contributor

itamarst commented Oct 27, 2022

This would enable re-releasing the yanked .12 release, seems like a good idea.

@itamarst itamarst mentioned this pull request Jan 6, 2023
Closed
@itamarst
Copy link
Contributor

itamarst commented Apr 6, 2023

Any chance this can be merged and a new release made? Thanks!

@dimbleby dimbleby mentioned this pull request May 16, 2023
Closed
@dimbleby dimbleby mentioned this pull request May 23, 2023
Closed
@frostming frostming merged commit 81ef6ba into psf:master May 29, 2023
@dimbleby dimbleby deleted the packaging-tests branch May 29, 2023 08:43
This was referenced May 30, 2023
Closed
Closed
@KOLANICH
Copy link

KOLANICH commented May 31, 2023

Thanks for fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No tests in pypi sdist tarball

4 participants

@dimbleby @itamarst @KOLANICH @frostming