Fix formatting of backslash escaped quote inside f-string#4365
Closed
hauntsaninja wants to merge 1 commit intopsf:mainfrom
Closed
Fix formatting of backslash escaped quote inside f-string#4365hauntsaninja wants to merge 1 commit intopsf:mainfrom
hauntsaninja wants to merge 1 commit intopsf:mainfrom
Conversation
| and any( | ||
| "\\" not in str(child) | ||
| for child in node.children | ||
| if node.type == syms.fstring_replacement_field |
Collaborator
There was a problem hiding this comment.
Suggested change
| if node.type == syms.fstring_replacement_field | |
| if child.type == syms.fstring_replacement_field |
Collaborator
|
Personally I'd rewrite it like so: if (
"\\" in string_leaf.value
and any(
"\\" in str(child)
for child in node.children
if child.type == syms.fstring_replacement_field
)
):
# string normalization doesn't account for nested quotes,
# causing breakages. skip normalization when nested quotes exist
yield from self.visit_default(string_leaf)
return
yield from self.visit_STRING(string_leaf) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4350