Skip to content

Fix cache file length#4176

Merged
JelleZijlstra merged 4 commits intopsf:mainfrom
JelleZijlstra:fixcache
Jan 26, 2024
Merged

Fix cache file length#4176
JelleZijlstra merged 4 commits intopsf:mainfrom
JelleZijlstra:fixcache

Conversation

@JelleZijlstra
Copy link
Copy Markdown
Collaborator

  • Ensure total file length stays under 96
  • Hash the path only if it's too long
  • Proceed normally (with a warning) if the cache can't be read

Fixes #4172

Description

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

- Ensure total file length stays under 96
- Hash the path only if it's too long
- Proceed normally (with a warning) if the cache can't be read

Fixes psf#4172
Copy link
Copy Markdown
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and 32 chars is enough to be unique I believe.

@JelleZijlstra JelleZijlstra merged commit ed770ba into psf:main Jan 26, 2024
@JelleZijlstra JelleZijlstra deleted the fixcache branch January 26, 2024 19:54
@JelleZijlstra JelleZijlstra restored the fixcache branch September 10, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cache uses filenames that might be too long on some systems

3 participants