Hug parens also with multiline unpacking#3992
Merged
JelleZijlstra merged 12 commits intopsf:mainfrom Oct 30, 2023
Merged
Conversation
|
I only gave list/args as an example. But there's dict/kwargs unpacking too: def foo(**kwargs):
print(kwargs)
other = {"d": 4}
foo(**{
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa": 1,
"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb": 2,
"ccccccccccccccccccccccccccccccccc": 3,
**other,
}) |
|
diff-shades results comparing this PR (79b8eca) to main (5edd993). The full diff is available in the logs under the "Generate HTML diff report" step. |
Contributor
Author
|
Hmm, the linting is failing. Should we format Black with the edit: To answer my own question, the CI runs with |
This was referenced Oct 31, 2023
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As noted by @Avasam here, hugging parens with brackets on multiline dictionaries and lists as sole function parameters didn't take into account list/dict unpacking. This PR fixes that shortcoming.
Checklist - did you ...
CHANGES.mdif necessary?