Allow empty line after block open before a comment or compound statement#3967
Merged
JelleZijlstra merged 4 commits intopsf:mainfrom Oct 23, 2023
Merged
Conversation
|
diff-shades results comparing this PR (ebd9677) to main (0a37888). The full diff is available in the logs under the "Generate HTML diff report" step. |
Contributor
Author
|
How should the issue be handled? I can't close it, but do you want to keep it open still? |
This was referenced Nov 13, 2023
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tried to follow the discussion around empty lines after a block open from issue #3551. From what I gathered from the different issues linked to this, is that Black won't go back to allowing the empty line at block open, but loosening this rule a bit might be beneficial for some users. This PR enables empty lines after a block open for comments (# comments or """comments""") and compound statements, as suggested by @JelleZijlstra. I understand that this is a complicated topic and this change might not be accepted in the end, but just wanted to put this out there, as it seemed like a low-hanging fruit.
Checklist - did you ...
CHANGES.mdif necessary?