Standardise newlines after module-level docstrings#3287
Closed
Standardise newlines after module-level docstrings#3287
Conversation
Co-authored-by: Felix Hildén <[email protected]>
That was one heck of a merge conflict to resolve, phew!
Collaborator
Author
|
I should mention that @felix-hilden and I "approved" the original PR. We didn't actually mark our reviews as approving, but we liked the style change and approved of the implementation. |
|
diff-shades results comparing this PR (af30118) to main (af3de08). The full diff is available in the logs under the "Generate HTML diff report" step. |
Collaborator
Author
3 tasks
Contributor
|
I attempted a new rebase without the refactoring in #3932. Please consider reviewing it so that the new formatting can go into the |
Collaborator
Collaborator
|
Since #3932 was merged and this has a bunch of conflicts, I'll close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
I resolved the merge conflicts in #2996. This PR is that PR with a few tweaks on top.
Closes #2996, resolves #1872.
Checklist - did you ...