Describe the bug
Minor bug, but it seems that the extra dependencies for the d extra are being installed by default on 23.12.0. This can cause some issues on docker containers and such where gcc isn't installed, as the extra dependencies (aiohttp, and frozenlist) don't seem to have wheels.
To Reproduce
On a non-windows machine (I've done it on Ubuntu, and it also seems to happen on Linux github action runners) Make a new venv, source it, and install black:
python3 -m venv .venv
source .venv/bin/activate
pip install black
It will install requirements from the d extra as well;
Installing collected packages: platformdirs, packaging, tomli, multidict, idna, yarl, attrs, frozenlist, async-timeout, aiosignal, aiohttp, typing-extensions, click, pathspec, mypy-extensions, black
Successfully installed aiohttp-3.9.1 aiosignal-1.3.1 async-timeout-4.0.3 attrs-23.1.0 black-23.12.0 click-8.1.7 frozenlist-1.4.0 idna-3.6 multidict-6.0.4 mypy-extensions-1.0.0 packaging-23.2 pathspec-0.12.1 platformdirs-4.1.0 tomli-2.0.1 typing-extensions-4.9.0 yarl-1.9.4
Expected behavior
It shouldn't install with the aiohttp, frozenlist, and multidict dependencies.
Environment
Additional context
First seen in rickstaa/action-black#18
I think it has to do with: 85b1c71; in my pip logs, the new restrictions seem to show up as:
Collecting aiohttp>=3.7.4; sys_platform != "win32" or implementation_name != "pypy" and extra == "d"
i.e., the extra == "d" is ignored in favor of the sys platform not being windows, so the extras are always installed. I think a quick fix would be to wrap the extras in parenthesis. Happy to make a quick PR for that.
Describe the bug
Minor bug, but it seems that the extra dependencies for the
dextra are being installed by default on 23.12.0. This can cause some issues on docker containers and such wheregccisn't installed, as the extra dependencies (aiohttp, andfrozenlist) don't seem to have wheels.To Reproduce
On a non-windows machine (I've done it on Ubuntu, and it also seems to happen on Linux github action runners) Make a new venv, source it, and install black:
python3 -m venv .venv source .venv/bin/activate pip install blackIt will install requirements from the
dextra as well;Expected behavior
It shouldn't install with the
aiohttp,frozenlist, andmultidictdependencies.Environment
Additional context
First seen in rickstaa/action-black#18
I think it has to do with: 85b1c71; in my pip logs, the new restrictions seem to show up as:
i.e., the
extra == "d"is ignored in favor of the sys platform not being windows, so the extras are always installed. I think a quick fix would be to wrap the extras in parenthesis. Happy to make a quick PR for that.