Fix crash with f-string docstrings (#4019)

hauntsaninja · AlexWaygood · web-flow · commit ecbd9e8cf71f · 2023-11-06T16:58:43.000-08:00
Python does not consider f-strings to be docstrings, so we probably shouldn't be formatting them as such Fixes #4018 Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diff --git a/CHANGES.md b/CHANGES.md
@@ -13,6 +13,9 @@
 
 - Fix crash on formatting code like `await (a ** b)` (#3994)
 
+- No longer treat leading f-strings as docstrings. This matches Python's behaviour and
+  fixes a crash (#4019)
+
 ### Preview style
 
 - Multiline dictionaries and lists that are the sole argument to a function are now
diff --git a/src/black/nodes.py b/src/black/nodes.py
@@ -529,7 +529,7 @@ def is_docstring(leaf: Leaf) -> bool:
         return False
 
     prefix = get_string_prefix(leaf.value)
-    if "b" in prefix or "B" in prefix:
+    if set(prefix).intersection("bBfF"):
         return False
 
     if prev_siblings_are(
diff --git a/tests/data/cases/docstring_preview.py b/tests/data/cases/docstring_preview.py
@@ -58,7 +58,8 @@ def docstring_almost_at_line_limit():
 
 
 def docstring_almost_at_line_limit_with_prefix():
-    f"""long docstring................................................................"""
+    f"""long docstring................................................................
+    """
 
 
 def mulitline_docstring_almost_at_line_limit():
diff --git a/tests/data/cases/f_docstring.py b/tests/data/cases/f_docstring.py
@@ -0,0 +1,20 @@
+def foo(e):
+    f""" {'.'.join(e)}"""
+
+def bar(e):
+    f"{'.'.join(e)}"
+
+def baz(e):
+    F""" {'.'.join(e)}"""
+
+# output
+def foo(e):
+    f""" {'.'.join(e)}"""
+
+
+def bar(e):
+    f"{'.'.join(e)}"
+
+
+def baz(e):
+    f""" {'.'.join(e)}"""
diff --git a/tests/data/cases/preview_docstring_no_string_normalization.py b/tests/data/cases/preview_docstring_no_string_normalization.py
