Ensuring postAction and tearDown gets called on Action failure#74
Closed
stephan-dowding wants to merge 3 commits intopsake:masterfrom
Closed
Ensuring postAction and tearDown gets called on Action failure#74stephan-dowding wants to merge 3 commits intopsake:masterfrom
stephan-dowding wants to merge 3 commits intopsake:masterfrom
Conversation
Contributor
|
I'm interested in pulling this, but will need some specs to back it up. |
Author
|
Sorry for the delay!! |
|
Is there an update on this pull request? I would very much like this functionality also. |
Member
|
@stephan-dowding This looks good to me but given the age of this, there are some conflicts with the existing PR. I'm going to create a new one and include your changes. |
9 tasks
Member
|
Creating new PR #227 which is up to date with psake. Closing this one out. Thanks @stephan-dowding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick patch to fix a little bug bear of mine...
I normally expect things like
PostActionandTearDownto be called even if the mainActionhas failed. This is because it is natural for me to use things likePreActionandSetUpto reserve resources and setup the environment for theAction. I will then usePostActionandTearDownto release those resources and wind down the environment. Having all that stuff hanging around after a test failure was extremely annoying!I know I could have used
try...finallywithin myActionblocks, but these constructs felt like the natural and intended place for them, hence the pull request!