Skip to content

Support MS Build 17 (Visual Studio 2022)#326

Merged
HeyItsGilbert merged 1 commit intopsake:masterfrom
Thorarin:vs2022
Sep 30, 2024
Merged

Support MS Build 17 (Visual Studio 2022)#326
HeyItsGilbert merged 1 commit intopsake:masterfrom
Thorarin:vs2022

Conversation

@Thorarin
Copy link
Copy Markdown
Contributor

@Thorarin Thorarin commented Aug 31, 2022

Description

Adds MS Build 17 support (included with Visual Studio 2022).

Related Issue

Fixes #312

Motivation and Context

We have MS Build 16 and 17 installed on multiple TeamCity build agents, but the behavior of selecting the used version is not identical on all agents. Some of them select MS Build 17 as desired, while others select version 16, which lacks support for newer C# language versions, for example.

How Has This Been Tested?

Tested on TeamCity build agents of the company I'm consulting for.
Builds now succeed on agents that were failing before.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Note: Selecting MS Build 17 could perhaps arguably be considered a breaking change. In some edge cases our project files required some adjustments to make them build. However, the fact that the user installed the new version probably means they want to use it.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual Studio 2022 Support

2 participants