Description

1. Created a Pester test to assert that the -ContinueOnError parameter has the desired behaviour.
2. Removed the additional call stack pop from Invoke-Task, which was causing that test to fail.
3. Added a try...finally to Invoke-Task immediately after the task is pushed onto the stack. The finally block ensures that the task is always popped, even if the task fails. This resolved a new bug which surfaced, where if a task with -ContinueOnError depends on another task, which fails, the failed task would not pop itself from the stack, and when the dependent task tried to pop itself from the stack, it would actually pop the failed task, causing a validation error.

Related Issue

#295

Motivation and Context

As described in the issue, this is an issue which has broken a feature which previously worked.

How Has This Been Tested?

Created a new Pester test, and ran all existing tests locally.

Tested on Windows 10, Powershell 5.1.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.