Skip to content

Add support .net 4.8#281

Merged
devblackops merged 2 commits intopsake:masterfrom
granit1986:feature/add-support-net-4-8
May 18, 2019
Merged

Add support .net 4.8#281
devblackops merged 2 commits intopsake:masterfrom
granit1986:feature/add-support-net-4-8

Conversation

@granit1986
Copy link
Copy Markdown
Contributor

@granit1986 granit1986 commented May 17, 2019

Description

Added .net 4.8 to ConfigureBuildEnvironment.ps1, with only build tools 15.0

Related Issue

#280

Motivation and Context

How Has This Been Tested?

ci/cd tests are passing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@granit1986 granit1986 changed the title Feature/add support net 4 8 Add support .net 4.8 May 17, 2019
@devblackops devblackops self-requested a review May 18, 2019 06:52
@devblackops devblackops self-assigned this May 18, 2019
Copy link
Copy Markdown
Member

@devblackops devblackops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @granit1986. Thanks!

@devblackops devblackops merged commit 5fa61b0 into psake:master May 18, 2019
@granit1986 granit1986 deleted the feature/add-support-net-4-8 branch June 13, 2019 11:37
@mboltuc
Copy link
Copy Markdown
Contributor

mboltuc commented Oct 3, 2019

Curious, why only build tools 15?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants