Skip to content

Adding support for .net 4.7.2#257

Merged
devblackops merged 2 commits intopsake:masterfrom
dawoodmm:master
Aug 9, 2018
Merged

Adding support for .net 4.7.2#257
devblackops merged 2 commits intopsake:masterfrom
dawoodmm:master

Conversation

@dawoodmm
Copy link
Copy Markdown
Contributor

@dawoodmm dawoodmm commented Aug 7, 2018

Description

Added .net 4.7.2 to ConfigureBuildEnvironment.ps1, with only build tools 15.0
this follows the same patter already implemented for .net 4.7 and .net 4.7.2

Related Issue

#256

Motivation and Context

How Has This Been Tested?

ci/cd tests are passing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devblackops
Copy link
Copy Markdown
Member

LGTM @dawoodmm. Thanks!

@devblackops devblackops merged commit 635e357 into psake:master Aug 9, 2018
@devblackops devblackops self-requested a review August 9, 2018 04:15
@devblackops devblackops self-assigned this Aug 9, 2018
@dawoodmm
Copy link
Copy Markdown
Contributor Author

thanks @devblackops

devblackops added a commit to devblackops/psake that referenced this pull request Aug 11, 2018
I can't explain way, but the changes from PR psake#257 should have been
merged into master but they aren't there. This commit to to re-apply
them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants