Allow working with preloaded VSSetup module#249
Merged
devblackops merged 1 commit intopsake:masterfrom Mar 22, 2018
Merged
Conversation
Before trying to import VSSetup, check if it's not already loaded. This allows to work with VSSetup committed to repository, loading it either by psake-config.ps1 or manually in helper script. Somewhat fixes psake#241, because now you don't have to install and maintain additional modules on build servers.
Member
|
Makes sense @havranek1024. Thanks for the addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current implementation required VSSetup module to be installed in location where PowerShell can find it automatically. Now, before trying to import VSSetup, psake will check if it's not already loaded. This allows to work with VSSetup committed to repository, loading it either by psake-config.ps1 or manually in helper script.
Related Issue
Somewhat fixes #241, because now you don't have to install and maintain additional modules on build servers.
Motivation and Context
It's not always feasible to install additional modules on build server.
How Has This Been Tested?
I did not have VSSetup module installed. I have copied VSSetup module to a folder in repository. Then I modified psake-config.ps1 to include VSSetup.psd1 in $config.modules. After this psake used MSBuild 15 and build succeeded, whereas before the change it used version 14.
Types of changes
Checklist: