Skip to content

Allow working with preloaded VSSetup module#249

Merged
devblackops merged 1 commit intopsake:masterfrom
havranek1024:allow-local-vssetup
Mar 22, 2018
Merged

Allow working with preloaded VSSetup module#249
devblackops merged 1 commit intopsake:masterfrom
havranek1024:allow-local-vssetup

Conversation

@havranek1024
Copy link
Copy Markdown
Contributor

Description

Current implementation required VSSetup module to be installed in location where PowerShell can find it automatically. Now, before trying to import VSSetup, psake will check if it's not already loaded. This allows to work with VSSetup committed to repository, loading it either by psake-config.ps1 or manually in helper script.

Related Issue

Somewhat fixes #241, because now you don't have to install and maintain additional modules on build servers.

Motivation and Context

It's not always feasible to install additional modules on build server.

How Has This Been Tested?

I did not have VSSetup module installed. I have copied VSSetup module to a folder in repository. Then I modified psake-config.ps1 to include VSSetup.psd1 in $config.modules. After this psake used MSBuild 15 and build succeeded, whereas before the change it used version 14.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Before trying to import VSSetup, check if it's not already loaded. This allows to work with VSSetup committed to repository, loading it either by psake-config.ps1 or manually in helper script. Somewhat fixes psake#241, because now you don't have to install and maintain additional modules on build servers.
@devblackops devblackops self-requested a review March 22, 2018 04:34
@devblackops devblackops self-assigned this Mar 22, 2018
@devblackops
Copy link
Copy Markdown
Member

Makes sense @havranek1024. Thanks for the addition!

@devblackops devblackops merged commit 13c4ec6 into psake:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

psake 4.7 does not work with Visual Studio 2017

2 participants