Skip to content

Update build success msg to be more general: psake succeeded#244

Merged
devblackops merged 1 commit intomasterfrom
rkeithhill/change-build-success-message
Jan 4, 2018
Merged

Update build success msg to be more general: psake succeeded#244
devblackops merged 1 commit intomasterfrom
rkeithhill/change-build-success-message

Conversation

@rkeithhill
Copy link
Copy Markdown
Contributor

Fixes #239 where seeing "build succeeded" when in fact psake wasn't build anything. psake executes tasks which may perform a build or may run tests or may do any number of things which are not builds.

Description

Changes the build_success message from Build succeeded to psake succeeded executing <build-file-path>

Related Issue

#239

Motivation and Context

The current message in the context of a larger log file is misleading and isn't easy to "pin to" psake. I might have an overall build process that uses many different tools to build. Seeing "Build succeeded" isn't specific enough. I want to know that output came from psake.

How Has This Been Tested?

Manually testing by running Invoke-psake specs\calling_invoke-task_should_pass.ps1.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #239 where seeing "build succeeded" when in fact psake wasn't build anything.  psake executes tasks which may perform a build or may run tests or may do any number of things which are not builds.
@rkeithhill rkeithhill requested a review from devblackops January 4, 2018 00:30
Copy link
Copy Markdown
Member

@devblackops devblackops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @rkeithhill. Thanks!

@devblackops devblackops merged commit 9fdc038 into master Jan 4, 2018
@rkeithhill rkeithhill deleted the rkeithhill/change-build-success-message branch January 4, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider changing message "Build succeeded!" to "Task succeeded"

2 participants