Update build success msg to be more general: psake succeeded#244
Merged
devblackops merged 1 commit intomasterfrom Jan 4, 2018
Merged
Update build success msg to be more general: psake succeeded#244devblackops merged 1 commit intomasterfrom
devblackops merged 1 commit intomasterfrom
Conversation
Fixes #239 where seeing "build succeeded" when in fact psake wasn't build anything. psake executes tasks which may perform a build or may run tests or may do any number of things which are not builds.
devblackops
reviewed
Jan 4, 2018
Member
devblackops
left a comment
There was a problem hiding this comment.
This looks good to me @rkeithhill. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239 where seeing "build succeeded" when in fact psake wasn't build anything. psake executes tasks which may perform a build or may run tests or may do any number of things which are not builds.
Description
Changes the build_success message from
Build succeededtopsake succeeded executing <build-file-path>Related Issue
#239
Motivation and Context
The current message in the context of a larger log file is misleading and isn't easy to "pin to" psake. I might have an overall build process that uses many different tools to build. Seeing "Build succeeded" isn't specific enough. I want to know that output came from psake.
How Has This Been Tested?
Manually testing by running
Invoke-psake specs\calling_invoke-task_should_pass.ps1.Screenshots (if appropriate):
Types of changes
Checklist: