Skip to content

Change check for IsWindows so it doesn't gen error record#236

Merged
rkeithhill merged 1 commit intomasterfrom
rkeithhill/fix-iswindows-test
Nov 23, 2017
Merged

Change check for IsWindows so it doesn't gen error record#236
rkeithhill merged 1 commit intomasterfrom
rkeithhill/fix-iswindows-test

Conversation

@rkeithhill
Copy link
Copy Markdown
Contributor

@rkeithhill rkeithhill commented Nov 23, 2017

Fix #234

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rkeithhill rkeithhill added this to the v4.7.1 milestone Nov 23, 2017
Copy link
Copy Markdown
Member

@devblackops devblackops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rkeithhill
Copy link
Copy Markdown
Contributor Author

I'm pretty sure the Travis test failures have nothing to do with this change. I'm working on fix some of those failures in another PR.

@rkeithhill rkeithhill merged commit 5b77184 into master Nov 23, 2017
@HeyItsGilbert HeyItsGilbert deleted the rkeithhill/fix-iswindows-test branch September 21, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find a variable with the name 'IsWindows'.

2 participants