Skip to content

Add support for frameworks 4.6.2, 4.7 and 4.7.1#222

Merged
rkeithhill merged 2 commits intopsake:masterfrom
rkeithhill:rkeithhill/add-vs2017-support
Nov 9, 2017
Merged

Add support for frameworks 4.6.2, 4.7 and 4.7.1#222
rkeithhill merged 2 commits intopsake:masterfrom
rkeithhill:rkeithhill/add-vs2017-support

Conversation

@rkeithhill
Copy link
Copy Markdown
Contributor

Fix #201

This also adds support for using VSSetup module to find location of v15.0 build tools.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fix psake#201

This also adds support for using VSSetup module to find location of v15.0 build tools.
@rkeithhill rkeithhill added this to the v4.7.0 milestone Nov 9, 2017
@rkeithhill rkeithhill mentioned this pull request Nov 9, 2017
@rkeithhill rkeithhill changed the title Add support for framework 4.7, 4.7.1 Add support for frameworks 4.6.2, 4.7 and 4.7.1 Nov 9, 2017
@devblackops
Copy link
Copy Markdown
Member

Looks good @rkeithhill. Thanks!

Copy link
Copy Markdown
Member

@devblackops devblackops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I must say many of the issues/PRs in psake seem to deal with support for .Net frameworks. I haven't thought how, but there must be some type of way to make this work without constantly updating psake as new frameworks are released. An issue for another time. 😄

@rkeithhill
Copy link
Copy Markdown
Contributor Author

there must be some type of way to make this work without constantly updating psake as new frameworks are released. An issue for another time

Agreed! Thought the same thing as I was tweaking the script.

@rkeithhill rkeithhill merged commit 84ed382 into psake:master Nov 9, 2017
@rkeithhill rkeithhill deleted the rkeithhill/add-vs2017-support branch November 9, 2017 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Build Tools 15 (Visual Studio 2017)

2 participants