(GH185) Use more descriptive default build file name of psakefile.ps1#196
Merged
devblackops merged 11 commits intopsake:masterfrom Nov 9, 2017
Merged
Conversation
Previously the spec test for the Framework command expected that .Net 4.0 output a 4.0 version for MSBuild, however, Framework 4.0 will report the latest version of MSBuild e.g. 4.6.1. This commit changes the assertion to expect a regular expression which contains the major version of 4.
This commit adds test fixtures and spec tests for the default build file loading behaviour.
Previously if there was only one test file the build tester would fail as it was not an array type. This commit detects if the return type is not an array and if so, forces the return type by a simple array literal.
The default psake build file of default.ps1 is completely ambiguous without inspecting its contents. Rake has a Rakefile, bundle has a Gemfile etc. so instead, psake should use Psakefile.ps1 as the default build file name. This commit modifies the load behaviour for a default build file: - Refactored detecting the default build filename into it's own function - The `Get-DefaultBuildFile` will prefer to load the `buildFileName` file. If it does not exist it fall back to `legacyBuildFileName` and emit a deprecation warning if it exists. This allows all existing users to continue to use `default.ps1` and migrate to psakefile.ps1 when appropriate.
glennsarti
force-pushed
the
ticket/gh185/use-psakefile
branch
2 times, most recently
from
b0adb49 to
1e93c1b
Compare
This commit updates existing documentation with the new build file name and adds a page describing the changes and the rationale behind them.
Contributor
Author
|
bump |
Member
|
@glennsarti I haven't forgotten about this, just working my way through the todo list 😢 |
Contributor
Author
|
sok...I'll just keep bumping it :-) |
Member
|
I like it @glennsarti! |
rkeithhill
requested changes
Nov 9, 2017
README.md
Outdated
| [![Build status][appveyor-badge]][appveyor-build] | ||
| [![Build Status][travis-badge]][travis-build] | ||
| [![Join the chat at https://gitter.im/psake/psake][gitter-badge]][gitter] | ||
| [](https://ci.appveyor.com/project/psake/psake) |
Contributor
There was a problem hiding this comment.
We lost the changes I made on this one. I think we could just copy/paste the top and bottom of the file I committed to this one and we'd have it.
Contributor
There was a problem hiding this comment.
Or if it would be easier, you can go ahead and get this committed and I can resubmit another PR to put back my changes.
Contributor
Author
|
Is this the best place to be doing this in? i.e. Shouldn't these be in separate PRs? or at least on your own forks? |
rkeithhill
reviewed
Nov 9, 2017
Contributor
There was a problem hiding this comment.
I think @devblackops was trying to fix merge conflicts for this PR.
Member
|
Yep. Just fixing merge conflicts since there was a flurry of changes last night. |
theaquamarine
added a commit
to theaquamarine/ZLocation
that referenced
this pull request
Jan 21, 2018
default.ps1 is deprecated psake/psake#196
vors
pushed a commit
to vors/ZLocation
that referenced
this pull request
Jan 21, 2018
* Install psake from gallery rather than cloning * Install Pester from gallery rather than chocolatey * Change to use Assert-VerifiableMock Pester renamed Assert-VerifiableMocks to Assert-VerifiableMock, this causes a test to fail. * Rename default.ps1 to psakefile.ps1 default.ps1 is deprecated psake/psake#196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #185
The default psake build file of default.ps1 is completely ambiguous without
inspecting its contents. Rake has a Rakefile, bundle has a Gemfile etc. so
instead, psake should use Psakefile.ps1 as the default build file name.
This PR modifies the load behaviour for a default build file:
Refactored detecting the default build filename into it's own function
The
Get-DefaultBuildFilewill prefer to load thebuildFileNamefile. Ifit does not exist it fall back to
legacyBuildFileNameand emit a deprecationwarning if it exists. This allows all existing users to continue to use
default.ps1and migrate to psakefile.ps1 when appropriate.Adds tests for the behaviour
Updates documentation with the new behaviour