Skip to content

Added an option '-notr' to disable output of time report.#147

Merged
gep13 merged 1 commit intopsake:masterfrom
n-dimens:master
Jan 15, 2016
Merged

Added an option '-notr' to disable output of time report.#147
gep13 merged 1 commit intopsake:masterfrom
n-dimens:master

Conversation

@n-dimens
Copy link
Copy Markdown
Contributor

P.S.: My editor removes white space at the end of lines in the file en-US\psake.psm1-help.xml

@gep13
Copy link
Copy Markdown
Member

gep13 commented Jan 6, 2016

@dlwyatt what are your thoughts on this?

It looks good to me 👍

@dlwyatt
Copy link
Copy Markdown
Member

dlwyatt commented Jan 6, 2016

I don't really have an opinion on whether a new switch should be added to the command (API change). If you think it's valuable, then the implementation looks fine to me.

@gep13
Copy link
Copy Markdown
Member

gep13 commented Jan 6, 2016

@dlwyatt since it is a non mandatory, additive change, I don't see any reason to not accept it 😄

@gep13 gep13 modified the milestone: 4.6.0 Jan 15, 2016
@gep13
Copy link
Copy Markdown
Member

gep13 commented Jan 15, 2016

@svgorbunov thank you for your contribution to psake!

gep13 added a commit that referenced this pull request Jan 15, 2016
Added an option '-notr' to disable output of time report.
@gep13 gep13 merged commit a0da9f3 into psake:master Jan 15, 2016
@gep13 gep13 added the Feature label Jan 15, 2016
@n-dimens
Copy link
Copy Markdown
Contributor Author

You’re welcome :) I hope, I can contribute more.

P.S.: Sorry, if my English is bad. I use Google Translate :(

@gep13
Copy link
Copy Markdown
Member

gep13 commented Jan 17, 2016

@svgorbunov said...
P.S.: Sorry, if my English is bad. I use Google Translate :(

I had no issues in understanding you, so you are doing perfectly well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants