Skip to content

Cleanup MaxRetries and RetryTriggerErrorPattern in the context of Task. (#117 and #103)#138

Merged
gep13 merged 1 commit intopsake:masterfrom
rvdginste:cleanup
Jan 15, 2016
Merged

Cleanup MaxRetries and RetryTriggerErrorPattern in the context of Task. (#117 and #103)#138
gep13 merged 1 commit intopsake:masterfrom
rvdginste:cleanup

Conversation

@rvdginste
Copy link
Copy Markdown
Contributor

Related to #103 and closes #117.

@gep13
Copy link
Copy Markdown
Member

gep13 commented Dec 8, 2015

@rvdginste I am playing catch up a little bit here. Is this PR still required?

@rvdginste
Copy link
Copy Markdown
Contributor Author

@gep13 if you ask me, then, yes, this PR is required.
This PR removes dead code. This is code that should have been removed in #103, but was left in. #117 points the dead code out. This PR was written in response to #117.

@gep13 gep13 self-assigned this Jan 15, 2016
@gep13 gep13 added this to the v4.6.0 milestone Jan 15, 2016
gep13 added a commit that referenced this pull request Jan 15, 2016
Cleanup MaxRetries and RetryTriggerErrorPattern in the context of Task. (#117 and #103)
@gep13 gep13 merged commit 1f53985 into psake:master Jan 15, 2016
@gep13
Copy link
Copy Markdown
Member

gep13 commented Jan 15, 2016

@rvdginste thanks for the contribution! This will be included in the next release of psake. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused parameters maxRetries and retryTriggerErrorPattern in Task

2 participants