Add working directory option to Exec function#135
Closed
DaveSenn wants to merge 2 commits intopsake:masterfrom
DaveSenn:master
Closed
Add working directory option to Exec function#135DaveSenn wants to merge 2 commits intopsake:masterfrom DaveSenn:master
DaveSenn wants to merge 2 commits intopsake:masterfrom
DaveSenn:master
Conversation
Contributor
|
Because I use this pattern a lot in my scripts, I want to suggest to put the "Pop-Location" in a finally block. The end result would then be something like the following: If an exception is thrown in the body of the 'try' clause, then the script will still end up in the location it started from... |
Member
|
@DaveSenn what were your thoughts about the suggestion from @rvdginste? Did you want to incorporate it into your PR? Thanks! |
Contributor
|
@DaveSenn up |
DaveSenn
pushed a commit
to DaveSenn/psake
that referenced
this pull request
Jan 8, 2017
DaveSenn
pushed a commit
to DaveSenn/psake
that referenced
this pull request
Jan 8, 2017
DaveSenn
pushed a commit
to DaveSenn/psake
that referenced
this pull request
Jan 8, 2017
DaveSenn
pushed a commit
to DaveSenn/psake
that referenced
this pull request
Jan 8, 2017
Author
Member
|
Closing this out as the better solution using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be very useful to have an option to set the working directory when executing script blocks (For example if you want to run git in the root of your repository and not in the directory containing the script).
Because of this I added a workingDirectory option to the Exec function.
The option is optional. If specified the current path gets saved using Push-Location and the current location gets set to the specified working directory. After the script block is executed the location will be set back to the previous location.