Fix Ruby 2.7 compatibility in Pry::Slop#mehtod_missing #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@kyrylo may I draw your attention on this PR ? It's not particularly urgent, but I think that if it's fixed and released early, it will make the Ruby 2.7 upgrade much smoother for the general public. |
Member
|
Thanks. It also probably makes sense to test pry against 2.7 if Circle has it. |
Author
|
It has the first 2.7 preview, but it doesn't include that change. However you can test against I can open a PR when the next preview is released in a couple weeks if you'd like. |
Member
|
That would be great. I just don’t know how to allow failures on Circle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently an experimental feature has been merged in Ruby's master https://bugs.ruby-lang.org/issues/16150
In short
Symbol#to_swill return a frozen string, whereas before it would always return a new mutable string.Because of this
Pry::Slop#method_missingbreaks onruby-head.The fix is quite straightforward, I simply reworked the code a little bit to avoid mutating the string.