Fix injected failures not recoverable from on retry#95
Merged
Conversation
The failures app had two errors: a bad import path for Engine after the recent refactoring and calling close on the engine twice (once in the _FailureInjectionEngine and once by the caller of FailureInjectionApp.run()). I also introduced in error in the original PR for this app. The failure of a task was determined statically by the engine, rather than during task execution. This means that a task that was selected to fail would always fail even when retried by an executor. I used the following config to validate the new changes work. There will occasionally be parsl log messages indicating a task failed and is retried. [app] name = "failures" base = "cholesky" failure_rate = 0.25 failure_type = "import" [app.config] matrix_size = 100 block_size = 50 [engine.executor] name = "parsl-htex" retries = 3 [engine.executor.htex] max_workers_per_node = 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, a task was predetermined to fail before submission which meant executors with retry semantics could never recover. This changes failure prob to be computed in the task during execution.
Also adds/updates tests to work towards #65.
Fixes N/A
Type of Change
Testing
Added unit tests and tested with this config.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).