Skip to content

Increase timedelta in directory creation check#89

Merged
gpauloski merged 1 commit intomainfrom
test-failure
Jul 11, 2024
Merged

Increase timedelta in directory creation check#89
gpauloski merged 1 commit intomainfrom
test-failure

Conversation

@gpauloski
Copy link
Copy Markdown
Contributor

Description

The directory timestamp does not contain millisecond precision so if the directory is created towards the end of a second (e.g., 900ms) and the check takes place right after the second (e.g., 1.100 ms), due to rounding, it can appear as taking 2 seconds to create the directory (even though it only took 200 ms).

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

Tests pass now.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the internal Refactoring, style changes, testing, or code optimizations label Jul 11, 2024
@gpauloski gpauloski merged commit c98e730 into main Jul 11, 2024
@gpauloski gpauloski deleted the test-failure branch July 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactoring, style changes, testing, or code optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant